Add button to edit custom Wiki sidebar
What does this MR do?
Adds a shortcut button to customize the wiki sidebar, see #23109 (closed).
Screenshots (strongly suggested)
Desktop layout | Mobile layout |
---|---|
![]() |
![]() |
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides - [-] Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
changed milestone to %13.8
added frontend label
1 Warning 7abe0f25: Commits that change 30 or more lines across at least 3 files must describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
doc/user/project/wiki/index.md
The review does not need to block merging this merge request. See the:
- Technical Writers assignments for the appropriate technical writer for this review.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer backend Furkan Ayhan ( @furkanayhan
) (UTC+3, 2 hours ahead of@toupeira
)Igor Drozdov ( @igor.drozdov
) (UTC+3, 2 hours ahead of@toupeira
)frontend Justin Boyson ( @jboyson
) (UTC-6, 7 hours behind@toupeira
)Natalia Tepluhina ( @ntepluhina
) (UTC+1, same timezone as@toupeira
)test Quality for spec/features/*
Anastasia McDonald ( @a_mcdonald
) (UTC+13, 12 hours ahead of@toupeira
)Maintainer review is optional for test Quality for spec/features/*
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by 🤖 GitLab Bot 🤖mentioned in merge request !37587 (closed)
marked the checklist item Changelog entry as completed
marked the checklist item Documentation (if required) as completed
marked the checklist item Code review guidelines as completed
marked the checklist item Merge request performance guidelines as completed
marked the checklist item Style guides as completed
assigned to @lifrank1994
- Resolved by Markus Koller
@toupeira thank you so much for pair programming with me and giving me mentorship on this contribution. As someone who uses gitlab's wikis personally and professionally, I'm delighted to have been a part of this feature improvement!
Looking forward to more contributions in the future with the GL team!
added documentation label
removed missed:13.6 label
removed missed-deliverable label
- Resolved by Markus Koller
@fjsanpedro @jboyson could you please give this backend / frontend reviews if you're around next week?
This is a community contribution and replaces the previous MR at !37587 (closed).
The frontend styling is based on @tomquirk's previous suggestion at !37587 (comment 385172707), with some small tweaks (only some of those CSS classes seemed to be necessary).
added workflowin review label and removed workflowin dev label
- Resolved by Marcia Ramos
@marcia could you please give this a documentation review?
assigned to @marcia
removed Deliverable label
mentioned in issue #23109 (closed)
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits c8e5ce10 and 6bb68923
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.04 MB 3.04 MB - 0.0 % mainChunk 1.89 MB 1.89 MB - 0.0 %
Please look at the full report for more details
Read more about how this report works.
Generated by
DangerEdited by 🤖 GitLab Bot 🤖requested review from @fjsanpedro
- Resolved by Markus Koller
- Resolved by Markus Koller
- Resolved by Matthew Nearents
- Resolved by Markus Koller
requested review from @marcia
unassigned @marcia
added Technical Writing docsfeature twdoing labels
added UI text label
requested review from @jboyson and @ntepluhina
assigned to @ntepluhina
- Resolved by Markus Koller
unassigned @ntepluhina
assigned to @toupeira and unassigned @lifrank1994
assigned to @fjsanpedro
assigned to @marcia
unassigned @marcia
added twfinished label and removed twdoing label
unassigned @fjsanpedro
- Resolved by Douglas Barbosa Alexandre
@dbalexandre are you available to do a final backend maintainer review? We've got all other approvals so this would be ready to merge.
assigned to @dbalexandre
mentioned in commit ab3b75de
added workflowstaging label and removed workflowin review label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added releasedcandidate label