Skip to content

Add the edit modal for rotations and abstract add/edit form

What does this MR do?

A small MVC for #262862 where we add the UI for the edit modal and abstract the add/edit form to be a shared container set. This merge contains the UI only, the actual backend code will be hooked up once the backend of #262862 is ready.

🇺🇦 It is behind the feature flag oncall_schedules_mvc and the minimal license is GitLab Premium 👀 To check Enable feature flag=>Navigate to Operations/On-call schedule => Click Add schedule on empty state or direct link is your_project/-/oncall_schedules e.g. http://127.0.0.1:3000/gitlab-org/gitlab-shell/-/oncall_schedules. After a first schedule is created you'll be able to see it

Merge You are
Add base mutation 🤘
Add GraphQL mutation for edit modal when backend is ready TBA

Screenshots (strongly suggested)

Screenshot_2020-12-18_at_07.00.47

Screenshot_2020-12-18_at_07.00.51

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related to #262862

Merge request reports