Skip to content

Add rotation modal to create a new rotation and handle feedback

What does this MR do?

The follow up to !49955 (merged), where we allow the rotation modal to clear, show the user a success message and add supporting specs.

The next step of this merge is to extend the spec coverage via the Apollo mock, however that is left until the frontend of the rotation grid is hooked up from: !49680 (merged)

🇺🇦 It is behind the feature flag oncall_schedules_mvc and the minimal license is GitLab Premium 👀 To check Enable feature flag=>Navigate to Operations/On-call schedule => Click Add schedule on empty state or direct link is your_project/-/oncall_schedules e.g. http://127.0.0.1:3000/gitlab-org/gitlab-shell/-/oncall_schedules. After a first schedule is created you'll be able to see it

Merge You are
Add base mutation !49955 (merged)
Extend spec coverage for mutation 🤘

Screenshots (strongly suggested)

Screenshot_2020-12-17_at_12.48.53

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related to #262857 (closed)

Edited by David O'Regan

Merge request reports