Skip to content

Handle git errors when cleaning up MR refs

Patrick Bajao requested to merge pb-handle-git-errors-cleanup-refs into master

What does this MR do?

Gitlab::Git::Repository::GitError and Gitlab::Git::CommandError errors can get raised when trying to cleanup MR refs. This will result to the worker being retried and move to dead queue when failed after the retry limit.

We don't need to retry in this case as the job will be scheduled again when picked up by ScheduleMergeRequestCleanupRefsWorker that runs every minute via sidekiq cron.

Related to #293826 (closed) and #293827 (closed).

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Merge request reports