Move database spec helpers into separate directory
What does this MR do?
Related issue: gitlab-org/database-team/team-tasks#110 (closed)
Our current CI setup runs MR pipelines against PG11, while only running pipelines against PG12 nightly. This has occasionally led to breakages due to changes in pg_catalog tables between PG11 and 12.
In general, when editing migration helpers and other database-centric files, we'd like to run tests against the supported PG versions to ensure these types of problems are caught early. We have a number of files under spec/support/helpers that query the pg_catalog and can be prone to breaking across PG versions as well.
This MR moves all those spec helpers into a single directory so it can be watched by CI to trigger the appropriate database tests. This also ensures that as new helpers are added, they will be picked up by CI automatically.
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team