Skip to content

Add OncallShifts read service and specs

Sean Arnold requested to merge 262860-shifts-read-service into master

What does this MR do?

Code originally written by @syasonik, and extracted from !50006 (merged).

  • This adds a service which, given a time frame, can return shifts for a given rotation.
  • This is currently limited to return generated shifts, but will be extended to return persisted shifts too in a later MR.

#262860 (closed) is comprised of several pieces:

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #262860 (closed)

Edited by Sean Arnold

Merge request reports