Skip to content

Use blob ID instead of `content_sha`

Thomas Randolph requested to merge feature/file-reviews/use-blob-id into master

What does this MR do?

Switches the primary identifier for file reviews to use blob.id instead of the file's content_sha.

Merge Request Description
!49173 (merged)
!49174 (merged)
!49190 (merged)
!49208 (merged)
Various cleanup merge requests in preparation for this feature.
!49506 (merged) Identify diff files using the content_sha
We're here 👉🏻 Switch identification to use blob.id
!50033 (merged) Add tooling to add/remove reviews from LocalStorage to accommodate the file review feature
Add UI to review files

Screenshots (strongly suggested)

N/A, all backstage refactoring.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Thomas Randolph

Merge request reports