Skip to content

GitLab Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
GitLab
GitLab
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 34,860
    • Issues 34,860
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 1,204
    • Merge Requests 1,204
  • Requirements
    • Requirements
    • List
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Security & Compliance
    • Security & Compliance
    • Dependency List
    • License Compliance
  • Operations
    • Operations
    • Metrics
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • GitLab.org
  • GitLabGitLab
  • Merge Requests
  • !49982

Merged
Opened Dec 14, 2020 by Payton Burdette@pburdetteDeveloper0 of 13 tasks completed0/13 tasks

Job Trace polling solution

  • Overview 53
  • Commits 4
  • Pipelines 9
  • Changes 10

What does this MR do?

  • Revert's the work done in !48516 (merged) && !49752 (merged)
  • We move back to polling the trace endpoint all the time to prevent race conditions.
  • Makes the trace endpoint return a 204 if the job has not started or does not have a trace.

Goal

Do the same thing the above MR's did, prevent unnecessary polling and prevent the strain on Redis. Instead of using the FE solution that causes some race conditions due to job state, we move the solution to the BE. We will poll like the pervious implementation but return a 204 if the job does not have a trace. Meaning we will not go get resources until the job has started and has a trace.

How to test

  • Pause your local runner and start a job (it should be in a pending state), check the network tab to ensure the trace endpoint is called and returns a 204
  • Start a running job, switch to a new tab, switch back and ensure no trace endpoint calls were made while you were gone.
  • Ensure everything with the job traces is still working as expected 🙏 Can you cancel/retry a job and logs are shown etc.

This is a developer facing change and does not warrant a changelog.

Related to: #294197 (closed)

Also related: #293675 (closed)

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

  • Changelog entry
  • Documentation (if required)
  • Code review guidelines
  • Merge request performance guidelines
  • Style guides
  • Database guides
  • Separation of EE specific content

Availability and Testing

  • Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
  • Tested in all supported browsers
  • Informed Infrastructure department of a default or new setting change, if applicable per definition of done

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited Jan 04, 2021 by Payton Burdette
Assignee
Assign to
Reviewer
Request review from
13.8
Milestone
13.8 (Past due)
Assign milestone
Time tracking
Reference: gitlab-org/gitlab!49982
Source branch: pb-job-trace-polling-fix

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.