Skip to content

Draft: Convert groups form to use dropdown for visibility

What does this MR do?

Changes the visibility selector to be a dropdown instead of radio buttons.

This better aligns with the form used during registration and allows us to consolidate on a standard design for group creation as used during registration

Note: Changelog is in FOSS instead of ee since the ee changes are developer-facing only.

Validate locally

visit http://127.0.0.1:3000/groups/new

Screenshots (strongly suggested)

platform before after
desktop Screen_Shot_2020-12-14_at_2.42.50_PM Screen_Shot_2020-12-14_at_2.37.29_PM
mobile Screen_Shot_2020-12-14_at_2.43.03_PM Screen_Shot_2020-12-14_at_2.37.53_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #292058

Edited by Doug Stull

Merge request reports