Skip to content

Add form validation for schedules

What does this MR do?

A tiny MVC to follow: !49832 (merged) where we add a onBlur validation handler to the add/edit schedule modal form for oncall schedules.

🇺🇦 It is behind the feature flag oncall_schedules_mvc and the minimal license is GitLab Premium 👀 To check Enable feature flag=>Navigate to Operations/On-call schedule => Click Add schedule on empty state or direct link is your_project/-/oncall_schedules e.g. http://127.0.0.1:3000/gitlab-org/gitlab-shell/-/oncall_schedules. After a first schedule is created you'll be able to see it

Screenshots (strongly suggested)

Screenshot_2020-12-12_at_12.44.04

Screenshot_2020-12-12_at_12.44.10

Screenshot_2020-12-12_at_12.44.14

Screenshot_2020-12-12_at_12.44.26

Screenshot_2020-12-12_at_12.44.31

Screenshot_2020-12-12_at_12.44.37

Screenshot_2020-12-12_at_12.44.40

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related to #262860 (closed)

Merge request reports