Bump gitlab-styles to 5.3.0
This makes Style/AndOr enabled everywhere, not just in conditionals: https://gitlab.com/gitlab-org/gitlab-styles/-/merge_requests/63
Quick test:
$ git diff
diff --git a/app/models/ability.rb b/app/models/ability.rb
index 514e923c380..c5243e8ecfb 100644
--- a/app/models/ability.rb
+++ b/app/models/ability.rb
@@ -16,7 +16,7 @@ def users_that_can_read_project(users, project)
# read the given group.
def users_that_can_read_group(users, group)
DeclarativePolicy.subject_scope do
- users.select { |u| allowed?(u, :read_group, group) }
+ users.select { |u| allowed?(u, :read_group, group) and true }
end
end
$ bundle exec rubocop app/models/ability.rb
Inspecting 1 file
C
Offenses:
app/models/ability.rb:19:60: C: Style/AndOr: Use && instead of and.
users.select { |u| allowed?(u, :read_group, group) and true }
^^^