Skip to content

Update Audit Events navigation and visibility

Tan Le requested to merge 257514-allow-audit-events-page-for-more-roles into master

What does this MR do?

This MR attempts to achieve two things:

  • Relocate Audit Events submenu in Settings menu to be under Security & Compliance menu (for both Projects and Groups)
  • Adjust permission to view Audit Events to Developer role and above

Implementation

  • Rejig projects_helper, groups_helper and related haml to relocate Audit Events submenu
  • Incoporate read_project_audit_events and read_group_audit_events permission to both controller and view
  • Add more test coverage
  • Fix all QA tests related to menu relocations

📷 Screenshots (strongly suggested)

Menu relocation

Name Before After
Project project_before project_before
Group group_before group_after

Search page appearance by roles

Name Before After
Project Audit Events Maintainer and higher
project_maintainer_above
Developer
project_developer
Group Audit Events Owner and highergroup_owner_above Maintainer and Developer
group_developer_above

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #257514 (closed)

Edited by Tan Le

Merge request reports