Set dast_site_validation_id on validation create

What does this MR do?

this merge request ensures that the relevant dast_site is associated with the dast_site_validation once it is created.

Why?

we were previously not performing this update, which was resulting in another model (dast_site_profile) returning 'none' as a result of the association being missing. this was exacerbated by some assumptions made in test factories, which were always creating transitory dependencies implicitly.

Related Issue(s)

• #292739 (closed)

Does this MR meet the acceptance criteria?

Conformity

• Changelog entry behind feature flag
• Documentation (if required)
• Code review guidelines
• Merge request performance guidelines
• Style guides
• Database guides
• Separation of EE specific content

Availability and Testing

• Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
• Tested in all supported browsers
• Informed Infrastructure department of a default or new setting change, if applicable per definition of done

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

• Label as security and @ mention @gitlab-com/gl-security/appsec
• The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
• Security reports checked/validated by a reviewer from the AppSec team

changed milestone to %13.8

added Category:DAST backend devopssecure feature flag groupdynamic analysis sectionsec typebug labels

1 Message

CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, run the following: bin/changelog -m 49791 "Set dast_site_validation_id on validation create" If you want to create a changelog entry for GitLab EE, run the following instead: bin/changelog --ee -m 49791 "Set dast_site_validation_id on validation create" If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

Reviewer roulette

Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.

Category	Reviewer	Maintainer
backend	Steve Abrams (@sabrams) (UTC-7)	Igor Drozdov (@igor.drozdov) (UTC+3)

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

marked this merge request as draft

added 456 commits

• b9645a8e...cd3242a8 - 454 commits from branch master
• 07407922 - Set dast_site_validation_id validation created
• 5ba5164d - wip

Compare with previous version

added 1 commit

• 6dc89394 - wip

Compare with previous version

added 2 commits

• f230badf - wip
• 37166c91 - wip

Compare with previous version

added 1 commit

• c29af3d2 - wip

Compare with previous version

marked this merge request as ready

added 1 commit

• 275c8b77 - Set dast_site_validation_id validation created

Compare with previous version

added 1 commit

• 1f37dc41 - Set dast_site_validation_id validation created

Compare with previous version

added 1 commit

• 95dab5b9 - Set dast_site_validation_id validation created

Compare with previous version

added 1 commit

• 4a0dce00 - Set dast_site_validation_id validation created

Compare with previous version

changed milestone to %13.7

added 1 commit

• 40063e96 - Set dast_site_validation_id validation created

Compare with previous version

changed the description

hey @eurie can you do the first backend review when you have a moment?

assigned to @eurie and unassigned @philipcunningham

requested review from @eurie

mentioned in issue #292739 (closed)

mentioned in issue #241815 (closed)

assigned to @philipcunningham and unassigned @eurie

added 965 commits

• 40063e96...0675d91b - 964 commits from branch master
• 427c73ff - Set dast_site_validation_id validation created

Compare with previous version

added 1 commit

• 6b57552e - Address reviewer feedback

Compare with previous version

added 1 commit

• 6da756bc - Address reviewer feedback

Compare with previous version

assigned to @eurie and unassigned @philipcunningham

added 12 commits

• 6da756bc...6b3c45b0 - 10 commits from branch master
• a5c7e4f5 - Set dast_site_validation_id validation created
• 2db5f90b - Address reviewer feedback

Compare with previous version

changed milestone to %13.8

added missed:13.7 label

mentioned in issue gitlab-com/www-gitlab-com#5962 (closed)

assigned to @igor.drozdov and unassigned @eurie

requested review from @igor.drozdov

approved this merge request

assigned to @philipcunningham and unassigned @igor.drozdov

added 339 commits

• 2db5f90b...281fda79 - 337 commits from branch master
• 4b2d3afa - Set dast_site_validation_id validation created
• e39af17a - Address reviewer feedback

Compare with previous version

assigned to @igor.drozdov and unassigned @philipcunningham

resolved all threads

merged

mentioned in commit 24090a4b

added workflowstaging label

added workflowcanary label and removed workflowstaging label

added workflowproduction label and removed workflowcanary label

added releasedcandidate label