Standardize wiki header spacing
What does this MR do?
Standardizes styling of wiki header spacing to match that of issues. See #288328 (closed) for details of requirments.
Implementation Notes
- This removes usage of the
.nav-text. It isn't used in the issues header, and didn't seem to be required other than in integration specs, which I fixed. - This MR intentionally doesn't touch the
wikis/<page_name>route which displays the page. It uses thewiki-last-edit-bystyling in the header, which is different styling than the other titles. - There is a pre-existing broken responsive behavior in the header spacing between 768px and 992px width (see screenshot below). This already exists on master, so this should be handled in a separate issue
-
TODO: add issue for broken responsive behavior
-
Screenshots (strongly suggested)
Original requirements screenshots in issue: #288328 (closed)
The spacing around the edit form's header in Wiki doesn't match that of the Issue. They should be the same for consistency.
| Issue | Wiki |
|---|---|
 |
 |
Wiki Create
| Before | After |
|---|---|
 |
 |
Wiki Edit
| Before | After |
|---|---|
 |
 |
Wiki Changes (diff)
| Before | After |
|---|---|
 |
 |
Wiki History
| Before | After |
|---|---|
 |
 |
Wiki Pages
(Accessible via http://gdk.test:3000/root/test1/-/wikis/pages, not yet sure how to get to this through the UI)
| Before | After |
|---|---|
 |
 |
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Associated Issue
- Closes #288328 (closed)
Edited by Chad Woolley