Add artifacts:public boolean

Merged Matt Kasa requested to merge mattkasa-downloadable-artifacts into master

What does this MR do?

Adds an artifacts:public boolean, defaulted to true to maintain current behavior, but this allows a job to specify public: false to indicate that artifacts should not be made public to guests or anonymous users.

This would mitigate issues around builds producing artifacts that contain sensitive information due to artifact download only requiring guest or read_build access.

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Matt Kasa