Add issue header mobile dropdown loading state
What does this MR do?
This MR adds a loading state to the issue header mobile dropdown to give the user feedback that the action is in progress now that GlDropdown
has a loading
prop.
This MR also:
- Updates the state update error message to be more specific (and reuses an existing translatable string)
- Move some specs from
issuables
toissues
since they only test issues and not issues and merge requests
Screenshots (strongly suggested)
before | after |
---|---|
Screen_Recording_2020-12-10_at_5.44.18_pm | Screen_Recording_2020-12-10_at_5.45.34_pm |
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Coung Ngo