Skip to content
Snippets Groups Projects

Update controller and serializer entity for actually importing groups

Merged Illya Klymov requested to merge 249160-group-migration-import-one-group-frontend into master
All threads resolved!

What does this MR do?

This MR fixes passing data between BulkImportServiceController and relevant service to match expected format on frontend Also it fixes incorrect passing of session url. Without this fixes actual import #249160 (closed) via POST call was impossible

Alongside, it adds additional field to serializer to allow displaying links to relevant source groups as expected in #249157 (closed)

Screenshots (strongly suggested)

N/A

Does this MR meet the acceptance criteria?

Conformity

Edited by Illya Klymov

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • George Koltsov approved this merge request

    approved this merge request

  • Author Maintainer

    @brodock could you please review this one?

  • assigned to @brodock

  • Gabriel Mazetto
  • assigned to @brodock

  • Illya Klymov added 426 commits

    added 426 commits

    Compare with previous version

  • unassigned @brodock

  • assigned to @toupeira

  • Illya Klymov added 1 commit

    added 1 commit

    • ca8a709c - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Illya Klymov added 1 commit

    added 1 commit

    • faed41f2 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • assigned to @toupeira

  • Markus Koller resolved all threads

    resolved all threads

  • Markus Koller added 1 commit

    added 1 commit

    • 2a1c08d4 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Markus Koller approved this merge request

    approved this merge request

  • Markus Koller enabled an automatic merge when the pipeline for f0943949 succeeds

    enabled an automatic merge when the pipeline for f0943949 succeeds

  • Illya Klymov aborted the automatic merge because source branch was updated

    aborted the automatic merge because source branch was updated

  • Illya Klymov added 93 commits

    added 93 commits

    • 2a1c08d4...942be4c5 - 89 commits from branch master
    • 2c965ea0 - Fix passing params between bulk import controller and service
    • 401a7f27 - Address reviewer comments
    • 3af0238f - Apply 1 suggestion(s) to 1 file(s)
    • b6123526 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Author Maintainer

    Proactively making this again MWPS as @toupeira done, previous run reported merge conflicts with master (which is a bit weird, no conflicts were discovered), rebased to latest master

  • Illya Klymov enabled an automatic merge when the pipeline for d78771f6 succeeds

    enabled an automatic merge when the pipeline for d78771f6 succeeds

  • Illya Klymov aborted the automatic merge because source branch was updated

    aborted the automatic merge because source branch was updated

  • Illya Klymov added 136 commits

    added 136 commits

    • b6123526...c9f1648c - 132 commits from branch master
    • e5a4e694 - Fix passing params between bulk import controller and service
    • 53ae3892 - Address reviewer comments
    • 1a4b1701 - Apply 1 suggestion(s) to 1 file(s)
    • f0a5871c - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Illya Klymov enabled an automatic merge when the pipeline for 75bcf70a succeeds

    enabled an automatic merge when the pipeline for 75bcf70a succeeds

  • merged

  • Illya Klymov mentioned in commit d624ab80

    mentioned in commit d624ab80

  • added workflowcanary label and removed workflowstaging label

  • added workflowproduction label and removed workflowcanary label

  • 🤖 GitLab Bot 🤖 added groupimport and integrate label and removed 1 deleted label

    added groupimport and integrate label and removed 1 deleted label

  • Please register or sign in to reply
    Loading