Update controller and serializer entity for actually importing groups
What does this MR do?
This MR fixes passing data between BulkImportServiceController and relevant service to match expected format on frontend Also it fixes incorrect passing of session url. Without this fixes actual import #249160 (closed) via POST call was impossible
Alongside, it adds additional field to serializer to allow displaying links to relevant source groups as expected in #249157 (closed)
Screenshots (strongly suggested)
N/A
Does this MR meet the acceptance criteria?
Conformity
Merge request reports
Activity
changed milestone to %13.7
assigned to @xanf
Not adding changelog, since feature is unreleased and is behind feature flag
added feature flag typemaintenance labels
added 1 commit
- daf6884e - Fix passing params between bulk import controller and service
- Resolved by Illya Klymov
@georgekoltsov could you please review this one?
assigned to @georgekoltsov
added 1 commit
- 87ff2fa1 - Fix passing params between bulk import controller and service
added backend label
1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, run the following:
bin/changelog -m 49697 "Update controller and serializer entity for actually importing groups"
If you want to create a changelog entry for GitLab EE, run the following instead:
bin/changelog --ee -m 49697 "Update controller and serializer entity for actually importing groups"
If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer backend Saikat Sarkar ( @ssarka
) (UTC-7, 9 hours behind@xanf
)Jan Provaznik ( @jprovaznik
) (UTC+1, 1 hour behind@xanf
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by 🤖 GitLab Bot 🤖added 1 commit
- 69bad45d - Fix passing params between bulk import controller and service
added 1 commit
- 126259ac - Fix passing params between bulk import controller and service
mentioned in merge request !49699 (merged)
- Resolved by George Koltsov
unassigned @georgekoltsov
assigned to @georgekoltsov
unassigned @georgekoltsov
@brodock could you please review this one?
assigned to @brodock
- Resolved by Markus Koller
- Resolved by Illya Klymov
- Resolved by Markus Koller
@xanf I have a few suggestions.
unassigned @brodock
assigned to @brodock
added 426 commits
-
126259ac...cc0bc406 - 424 commits from branch
master
- c39b9a5c - Fix passing params between bulk import controller and service
- 83ffcc15 - Address reviewer comments
-
126259ac...cc0bc406 - 424 commits from branch
unassigned @brodock
assigned to @toupeira
- Resolved by Markus Koller
unassigned @toupeira
assigned to @toupeira
- Resolved by Markus Koller
enabled an automatic merge when the pipeline for f0943949 succeeds
added 93 commits
-
2a1c08d4...942be4c5 - 89 commits from branch
master
- 2c965ea0 - Fix passing params between bulk import controller and service
- 401a7f27 - Address reviewer comments
- 3af0238f - Apply 1 suggestion(s) to 1 file(s)
- b6123526 - Apply 1 suggestion(s) to 1 file(s)
Toggle commit list-
2a1c08d4...942be4c5 - 89 commits from branch
Proactively making this again MWPS as @toupeira done, previous run reported merge conflicts with master (which is a bit weird, no conflicts were discovered), rebased to latest master
enabled an automatic merge when the pipeline for d78771f6 succeeds
added 136 commits
-
b6123526...c9f1648c - 132 commits from branch
master
- e5a4e694 - Fix passing params between bulk import controller and service
- 53ae3892 - Address reviewer comments
- 1a4b1701 - Apply 1 suggestion(s) to 1 file(s)
- f0a5871c - Apply 1 suggestion(s) to 1 file(s)
Toggle commit list-
b6123526...c9f1648c - 132 commits from branch
enabled an automatic merge when the pipeline for 75bcf70a succeeds
mentioned in commit d624ab80
added workflowstaging label and removed workflowready for development label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
removed typefeature label
added groupimport and integrate label and removed 1 deleted label