Remove legacy_data? method on legacy burndown
What does this MR do?
Burndown is now legacy because we now use TimeboxReportService to generate burnup and burndown charts.
Burndown#legacy_data? is for checking legacy data before we had Burndown so this is not used anymore.
Removing this would speed up the milestone page because this is doing some expensive queries. (This can be seen when visiting https://gitlab.com/groups/gitlab-org/-/milestones/51 and checking the query stacktraces in the performance bar)
Related to gitlab-com/www-gitlab-com#10004 (closed)
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Heinrich Lee Yu