Skip to content

Resolve "Geo event-log pruning worker is not enabled/disabled by the sidekiq cron manager"

Nick Thomas requested to merge (removed):5269-manage-geo-prune-event-log-worker into master

What does this MR do?

Adds the geo-primary-only Geo::PruneEventLogWorker cron job to the Geo sidekiq-cron manager

Are there points in the code the reviewer needs to double check?

Are there any reasons why this cron was excluded from this mechanism to begin with? It has a return unless Gitlab::Geo.primary? guard, so it's definitely a primary-only job...

Why was this MR needed?

Without this, we don't start pruning the event log when a secondary is updated to a primary until after a restart.

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • Tests added for this feature/bug
  • Review
    • Has been reviewed by Backend
  • Conform by the merge request performance guides
  • Conform by the style guides
  • Squashed related commits together
  • Internationalization required/considered
  • If paid feature, have we considered GitLab.com plan and how it works for groups and is there a design for promoting it to users who aren't on the correct plan
  • End-to-end tests pass (package-qa manual pipeline job)

What are the relevant issue numbers?

Closes #5269 (closed)

Edited by Nick Thomas

Merge request reports