Skip to content

Switch to using GlSort for group members view

What does this MR do?

Related to #228675 (closed) and #292042 (closed)

As a follow-up to !49168 (comment 461485637) this MR switches from using GlDropdown to GlSort for the sorting on the group members view

Local testing

  1. Enable the group_members_filtered_search feature flag
    • bin/rails console
    • Feature.enable(:group_members_filtered_search)
  2. Create a group
  3. Add members in Group -> "Members"
  4. Use the filter bar and sort dropdown

Screenshots (strongly suggested)

Desktop

Before After
Screen_Shot_2020-12-08_at_6.42.10_PM Screen_Shot_2020-12-08_at_6.39.22_PM

Mobile

Before After
Screen_Shot_2020-12-08_at_6.42.43_PM Screen_Shot_2020-12-08_at_6.40.39_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Peter Hegman

Merge request reports