Skip to content

Default emoji icon persists in issues and mrs header

What does this MR do?

Fixes a persistent emoji icon in issue and MR headers.

  • Ensures we check show_emoji_status? in the issuable_meta method
  • Adds related specs to issueables_helper_spec

Note: it's not currently possible for a user to set :speech_balloon: as their emoji status without setting the message or availability, see here and here

Screenshots (strongly suggested)

Before

With no status set, the default emoji is still appearing

Issues Merge requests
Screen_Shot_2020-12-08_at_1.31.31_pm Screen_Shot_2020-12-08_at_1.31.01_pm

After

Page Without status set With status
Issues Screen_Shot_2020-12-08_at_12.59.34_pm Screen_Shot_2020-12-08_at_12.59.59_pm
Merge requests Screen_Shot_2020-12-08_at_1.41.01_pm Screen_Shot_2020-12-08_at_1.41.19_pm

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #284601 (closed)

Edited by Ezekiel Kigbo

Merge request reports