Resolve "Follow-up from "Store lfs on object storage by default""
What does this MR do?
When generating S3 compatible URLs we should respect user configuration in
congig/gitlab.yml
In GDK we are using local minio
over HTTP.
Are there points in the code the reviewer needs to double check?
~~This change triggers a ~bug in upstream deps fog-google
, we need fog/fog-google!310 to be merged and released.~~ fog-google v1.3.2
released
Why was this MR needed?
Without this fix gdk
+minio
generates broken URLs
Screenshots (if relevant)
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
API support added -
Tests added for this feature/bug - Review
-
Has been reviewed by UX -
Has been reviewed by Frontend -
Has been reviewed by Backend -
Has been reviewed by Database
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Squashed related commits together -
Internationalization required/considered -
If paid feature, have we considered GitLab.com plan and how it works for groups and is there a design for promoting it to users who aren't on the correct plan -
End-to-end tests pass ( package-qa
manual pipeline job)
What are the relevant issue numbers?
Closes #5167 (closed)
Edited by Alessio Caiazza