Skip to content

Resolve "Follow-up from "Store lfs on object storage by default""

Alessio Caiazza requested to merge 5167-lfs-objecstorage-gdk into master

What does this MR do?

When generating S3 compatible URLs we should respect user configuration in congig/gitlab.yml

In GDK we are using local minio over HTTP.

Are there points in the code the reviewer needs to double check?

~~This change triggers a ~bug in upstream deps fog-google, we need fog/fog-google!310 to be merged and released.~~ fog-google v1.3.2 released

Why was this MR needed?

Without this fix gdk+minio generates broken URLs

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #5167 (closed)

Edited by Alessio Caiazza

Merge request reports