Remove initial alert service values from operations settings
What does this MR do?
Related issue: #255501 (closed)
When Settings > Operations is initialized, a bunch of data is included with the request. This includes attributes of an AlertsService
(found or initialized). As AlertsService
is no longer used for managing generic alerting integrations (replaced by HttpIntegrations
), we do not need to include attributes specific to the alerts service.
Caveat: AlertsService
is still used for an MVC of an integration with OpsGenie, which will be deprecated in %13.8. This is EE-only.
This MR moves the alerts service initialization to EE & removes the alerts service attributes which are no longer needed by the FE. OpsGenie functionality remains unaffected.
As there are no user-facing changes, there will be no changelog included.
Screenshots (strongly suggested)
Settings > Operations > Alerts when creating a new HTTP integration | New HTTP integration after save |
---|---|
![]() |
![]() |
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
- [-] Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team