Skip to content

Add sort dropdown to group members view

What does this MR do?

In an effort to move to using the filtered search bar for the group members view this is the last MR to complete #228675 (closed). This MR adds the sorting dropdown next to the filtered search bar (was implemented in !48272 (merged)).

Local testing

  1. Enable the group_members_filtered_search feature flag
    • bin/rails console
    • Feature.enable(:group_members_filtered_search)
  2. Create a group
  3. Add members in Group -> "Members"
  4. Use the filter bar and sort dropdown

Screenshots (strongly suggested)

Desktop

Before After
Screen_Shot_2020-12-03_at_4.30.59_PM Screen_Shot_2020-12-03_at_4.22.07_PM

Mobile

Before After
Screen_Shot_2020-12-03_at_4.32.25_PM Screen_Shot_2020-12-03_at_4.22.32_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Peter Hegman

Merge request reports