Remove unnecessary js from admin/groups/edit
What does this MR do?
From my investigation of editing a page like http://127.0.0.1:3000/admin/groups/jashkenas/edit, the ldap items are not present. So we should remove from the admin/groups/edit page specific javascript.
no changelog provided as this is a developer-facing change only
Validating visually
Visit admin area on gdk -> groups -> edit any group...similar should be: http://127.0.0.1:3000/admin/groups/fdg/edit
Investigation Details
Further investigation shows that ajax-ldap-groups-select that is references in is only used in http://gitlab.com/gitlab-org/gitlab/blob/378307bc77b21a91bade272a9dbe8eac564033ba/ee/app/views/ldap_group_links/_form.html.haml#L28-28, which is called by http://gitlab.com/gitlab-org/gitlab/blob/378307bc77b21a91bade272a9dbe8eac564033ba/ee/app/views/groups/ldap_group_links/index.html.haml#L7-7, which is invoked by http://gitlab.com/gitlab-org/gitlab/blob/378307bc77b21a91bade272a9dbe8eac564033ba/ee/app/controllers/groups/ldap_group_links_controller.rb#L13-13, which finally is linked to via the settings nav which is only called inside a group's scope and not in the GitLab instance's admin area
Screenshots (strongly suggested)
This is what the page looks like that does use this javascript(not the page I'm changing here)
Page we are editing here - admin -> groups -> edit
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #284118