Skip to content

Resolve "Forward an E-Mail to an existing issue as a new comment"

What does this MR do?

Add a new email handler for forwarding emails to an issue. This is a unique email address per user and per issue, just like the unique project email. Format is

incoming+<project_path>-<project_id>-<Author_token>-issue-<issue_iid>@incoming.gitlab.com

for example

incoming+gitlab-org-gitlab-ce-20-Author_Token12345678-issue-34@incoming.gitlab.com

The email and it's attachments will be added as a new comment to the issue. Unlike direct replies that strip out all quoted conversations, the entire conversation is added to the issue. This works the same way as creating a new issue by email.

For testing, you can copy the issue creation email and add the issue id, -<issue_id>

MR !50127 (merged) is the UI portion which exposes the email address to the user.

A feature flag was not deemed necessary for this feature. It is a simple extension of our already well tested reply and note creation email handling code. If a problem occurs, it would only effect the specific sidekiq job handling email, and the email would not get added to the issue as a comment.

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #18816 (closed)

Edited by Michael Kozono

Merge request reports