Skip to content

Resolve ""400 Bad Request" during authentication due to password format (length or special chars)"

What does this MR do?

Due to recent changes authorization through command line when password include special characters was returning 400 error.

I have added changes that handle credentials slightly differently in lib/gitlab/middleware/handle_malformed_strings.rb rack middleware.

Screenshots (strongly suggested)

before: image



Does this MR meet the acceptance criteria?


Availability and Testing


If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #285076 (closed) and #288324 (closed)

Edited by Gosia Ksionek

Merge request reports