Skip to content

Replace max width 90% from job dropdown with a min-width of 0

Frédéric Caplette requested to merge fc-ci-graph-css-cleanup into master

What does this MR do?

To ensure that the text was cut off properly in the job dropdown component, there was a max-width of 90% which was working properly, but was a bit more flaky than this solution based on having the flex items have a min-width of 0. We also remove unused classes. One example of a blog with more information: https://makandracards.com/makandra/66994-css-flex-and-min-width

This shouldn't change anything visually and simply be a more long term solution. No changelog required as the change is not user facing.

Screenshots (strongly suggested)

Before After
Screen_Shot_2020-12-02_at_10.52.19_AM Screen_Shot_2020-12-02_at_10.51.43_AM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Jose Ivan Vargas

Merge request reports