Skip to content

Global Search - Fix Dark Mode Font

Zack Cuddy requested to merge 281023-fix-darkmode-searc into master

What does this MR do?

Closes #281023 (closed)

When highlighting Search Keywords in the results we used the color Black explicitly. This causes an issue with Dark Mode as the font becomes unreadable.

This change changes the implementation to use the font variable gl-text-gray-900 instead of gl-text-black-normal.

Screenshots (strongly suggested)

Light Mode Dark Mode
Basic Basic_-_Light Basic_-_Dark
Advanced Advanced_-_Light Advanced_-_Dark

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related to #281023 (closed)

Edited by Michael Kozono

Merge request reports