Skip to content
Snippets Groups Projects

Add admin users vue app wrapper

Merged Jiaan Louw requested to merge 285104-create-admin-users-vue-app into master

What does this MR do?

Part of Migrate admin/users to Vue MVP &4961 (closed).

This adds a Vue app wrapper to admin/users as a first step to converting the page from HAML to Vue.

For the MVP we're passing the data from HAML to Vue via data-attributes, once this MR is merged work can begin to migrate to GraphQL #290276.

Local Testing & Setup

  1. Enable the development feature flag in rails console Feature.enable(:vue_admin_users)
  2. Visit /admin/users and check that the Vue app is showing in the Vue console with the correct props

Screenshots (strongly suggested)

Can only be viewed using Vue Dev Tools
image

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related to #285104 (closed)

Edited by Robert Hunt

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Jiaan Louw
  • Jiaan Louw
  • Jiaan Louw added 1 commit

    added 1 commit

    • 8d518d4c - Add admin users vue app wrapper

    Compare with previous version

  • Robert Hunt mentioned in merge request !48791 (merged)

    mentioned in merge request !48791 (merged)

  • Jiaan Louw marked this merge request as ready

    marked this merge request as ready

  • Jiaan Louw added 2221 commits

    added 2221 commits

    Compare with previous version

  • added typemaintenance label and removed featureenhancement label

  • Jiaan Louw marked this merge request as draft

    marked this merge request as draft

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading