Add admin users vue app wrapper
What does this MR do?
Part of Migrate admin/users to Vue MVP
&4961 (closed).
This adds a Vue app wrapper to admin/users as a first step to converting the page from HAML to Vue.
For the MVP we're passing the data from HAML to Vue via data-attributes, once this MR is merged work can begin to migrate to GraphQL #290276.
Local Testing & Setup
- Enable the development feature flag in rails console
Feature.enable(:vue_admin_users)
- Visit
/admin/users
and check that the Vue app is showing in the Vue console with the correct props
Screenshots (strongly suggested)
Can only be viewed using Vue Dev Tools |
---|
![]() |
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry -
Behind a feature flag
- [-] Documentation (if required) -
No visual changes
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
- [-] Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Related to #285104 (closed)
Merge request reports
Activity
changed milestone to %13.7
added backend label
1 Warning This merge request changed files with disabled eslint rules. Please consider fixing them. 1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, run the following:
bin/changelog -m 48922 "Add admin users vue app wrapper"
If you want to create a changelog entry for GitLab EE, run the following instead:
bin/changelog --ee -m 48922 "Add admin users vue app wrapper"
If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Disabled eslint rules
The following files have disabled
eslint
rules. Please consider fixing them:app/assets/javascripts/pages/admin/users/index.js
Run the following command for more details
node_modules/.bin/eslint --report-unused-disable-directives --no-inline-config \ 'app/assets/javascripts/pages/admin/users/index.js'
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer backend Adrien Kohlbecker ( @akohlbecker
) (UTC+1, 1 hour behind@jiaan
)Rémy Coutable ( @rymai
) (UTC+1, 1 hour behind@jiaan
)frontend Tom Quirk ( @tomquirk
) (UTC+10, 8 hours ahead of@jiaan
)Jacques Erasmus ( @jerasmus
) (UTC+2, same timezone as@jiaan
)test Quality for spec/features/*
Adrien Kohlbecker ( @akohlbecker
) (UTC+1, 1 hour behind@jiaan
)Maintainer review is optional for test Quality for spec/features/*
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by 🤖 GitLab Bot 🤖assigned to @rob.hunt
unassigned @jiaan
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits bcf59315 and 37b956f7
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.03 MB 3.03 MB - 0.0 % mainChunk 1.88 MB 1.88 MB - 0.0 %
Note: We do not have exact data for bcf59315. So we have used data from: b6d8d327.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerEdited by 🤖 GitLab Bot 🤖- Resolved by Robert Hunt
- Resolved by Mikołaj Wawrzyniak
- Resolved by Mikołaj Wawrzyniak
mentioned in merge request !48791 (merged)
added 2221 commits
-
8d518d4c...b2c841a0 - 2220 commits from branch
master
- 97882050 - Add admin users vue app wrapper
-
8d518d4c...b2c841a0 - 2220 commits from branch
added typemaintenance label and removed featureenhancement label