Skip to content

Fix keyword args warning on cycle analytics specs

Tan Le requested to merge 257438-fix-keyword-args-cycle-analytics into master

What does this MR do?

Related issue: #257438 (closed)

This fixes the following warning.

RUBYOPT="-W:deprecated" bundle exec spring rspec spec/lib/gitlab/cycle_analytics/

/builds/gitlab-org/gitlab/lib/gitlab/cycle_analytics/builds_event_helper.rb:10: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
/builds/gitlab-org/gitlab/lib/gitlab/cycle_analytics/code_event_fetcher.rb:17: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
/builds/gitlab-org/gitlab/lib/gitlab/cycle_analytics/issue_event_fetcher.rb:15: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
/builds/gitlab-org/gitlab/lib/gitlab/cycle_analytics/permissions.rb:16: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
/builds/gitlab-org/gitlab/lib/gitlab/cycle_analytics/plan_event_fetcher.rb:15: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
/builds/gitlab-org/gitlab/lib/gitlab/cycle_analytics/production_event_fetcher.rb:16: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
/builds/gitlab-org/gitlab/lib/gitlab/cycle_analytics/review_event_fetcher.rb:16: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
/builds/gitlab-org/gitlab/lib/gitlab/cycle_analytics/updater.rb:7: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Tan Le

Merge request reports