Skip to content

GitLab Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
GitLab
GitLab
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 34,978
    • Issues 34,978
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 1,267
    • Merge Requests 1,267
  • Requirements
    • Requirements
    • List
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Security & Compliance
    • Security & Compliance
    • Dependency List
    • License Compliance
  • Operations
    • Operations
    • Metrics
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • GitLab.org
  • GitLabGitLab
  • Merge Requests
  • !48696

Merged
Opened Nov 27, 2020 by Miguel Rincon@mrincon🚀Maintainer3 of 9 tasks completed3/9 tasks

Render pipelines without DOMContentLoaded

  • Overview 11
  • Commits 1
  • Pipelines 3
  • Changes 5

What does this MR do?

Render pipelines without DOMContentLoaded

This change removes the callback on DOMContentLoaded to render the pipelines and instead renders them immediately.

It also improves the code by making the init function more consistent with the rest of the codebase. In initial tests on my browser it seems to speed up the rendering of the pipelines list.

Related to #285125

Screenshots (strongly suggested)

LCP was slightly better in most cases on my browser:

before (4+ secs) after (<4 secs)
Screen_Shot_2020-11-30_at_10.31.58_AM Screen_Shot_2020-11-30_at_10.29.09_AM

Sample page can be reached by selecting project and Pipelines: http://gdk.test:3000/root/my-ci-variables/-/pipelines?page=1&scope=all

image

Does this MR meet the acceptance criteria?

Conformity

  • [-] Changelog entry
  • [-] Documentation (if required)
  • Code review guidelines
  • Merge request performance guidelines
  • Style guides
  • [-] Database guides
  • [-] Separation of EE specific content

Availability and Testing

  • Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
  • Tested in all supported browsers
  • Informed Infrastructure department of a default or new setting change, if applicable per definition of done

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited Dec 01, 2020 by Miguel Rincon
Assignee
Assign to
Reviewer
Request review from
13.7
Milestone
13.7 (Past due)
Assign milestone
Time tracking
Reference: gitlab-org/gitlab!48696
Source branch: 285125-reduce-pipelines-lcp-dom

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.