Skip to content

Render pipelines without DOMContentLoaded

Miguel Rincon requested to merge 285125-reduce-pipelines-lcp-dom into master

What does this MR do?

Render pipelines without DOMContentLoaded

This change removes the callback on DOMContentLoaded to render the pipelines and instead renders them immediately.

It also improves the code by making the init function more consistent with the rest of the codebase. In initial tests on my browser it seems to speed up the rendering of the pipelines list.

Related to #285125 (closed)

Screenshots (strongly suggested)

LCP was slightly better in most cases on my browser:

before (4+ secs) after (<4 secs)
Screen_Shot_2020-11-30_at_10.31.58_AM Screen_Shot_2020-11-30_at_10.29.09_AM

Sample page can be reached by selecting project and Pipelines: http://gdk.test:3000/root/my-ci-variables/-/pipelines?page=1&scope=all

image

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Miguel Rincon

Merge request reports