Skip to content

Github Importer - Import pull request reviews

Kassio Borges requested to merge kassio/github-import-review-comments into master

What does this MR do?

Github has the concept of pull request reviews, where a user can add a comment with the type: "APPROVED", "CHANGES_REQUESTED" or "COMMENTED".

This commit introduces the ability to import this type of comments from Github.

For the "APPROVED" type, if the author of the comment can be mapped to a Gitlab user, an merge request approval is created.

For all the types a note is added to the merge request. If the author of the review cannot be mapped to a Gitlab user a complementary text is added to the original review body informing the original author of the review.

Screenshots (strongly suggested)

Update_README_md___4____Merge_Requests___Administrator___foobar___GitLab

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Kassio Borges

Merge request reports