Skip to content

Revert "Update npm.gitlab-ci.yml to make CI job fail on error"

Shinya Maeda requested to merge revert-4ae4c89d into master

What does this MR do?

This MR reverts the change introduced by !38984 (merged). @nfriend commented :

Hey @palashbansal96 @f_caplette @shinya.maeda 👋 Just noticed this change to this template. This implies that any commit that does not bump the version in package.json will fail the pipeline, correct? I don't think this would be the desired behavior for most workflows. Not every pipeline should necessarily result in new release.

Ideally we would compare the version in package.json to the currently published version, and only attempt to run npm publish if they are different. I think should be possible now that #220985 (closed) has been fixed and we can use npm view to get the latest published version 🤔

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Shinya Maeda

Merge request reports