Revert "Update npm.gitlab-ci.yml to make CI job fail on error"
What does this MR do?
This MR reverts the change introduced by !38984 (merged). @nfriend commented :
Hey @palashbansal96 @f_caplette @shinya.maeda
👋 Just noticed this change to this template. This implies that any commit that does not bump the version inpackage.json
will fail the pipeline, correct? I don't think this would be the desired behavior for most workflows. Not every pipeline should necessarily result in new release.Ideally we would compare the version in
package.json
to the currently published version, and only attempt to runnpm publish
if they are different. I think should be possible now that #220985 (closed) has been fixed and we can usenpm view
to get the latest published version🤔
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team