Contain flash message in projects commit show page
What does this MR do?
The Problem:
Testing Case
- Go to Repository > Commits > Select a commit
- Trigger a flash message
-
The flash message will look like this:
| Inline View | Side-by-side View |
|---|---|
 |
 |
The most simple way to trigger a flash message is to manually set one in the flash partial file app/views/layouts/_flash.html.haml
Follow up Issue
I don't think my solution is the best as it adds custom CSS styles (we prefer to use utility class). What would be nice is if we can add additional classes to the flash container via an instance variable. Here's the issue for possibly implementat that > #287770
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #267751 (closed)
Edited by Samantha Ming