Skip to content

Add danger alert for misplaced changelogs with db changes

What does this MR do?

Adds a condition to report on misplaced changelog in these conditions:

  1. Migration exists in non ee
  2. Changelog exists in ee

The correct changelog placement in this scenario is inside FOSS due to this reason

Screenshots (strongly suggested)

With new condition

  • there are ee changes with an ee changelog, but a db migration exists.

Screen_Shot_2020-11-23_at_3.19.56_PM

With existing conditions(no change)

  • there are ee changes, no ee changelog, and no db migrations.

Screen_Shot_2020-11-23_at_3.47.24_PM

  • there are no ee changes, but an ee changelog exists.

Screen_Shot_2020-11-23_at_3.14.21_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #277398

Edited by Doug Stull

Merge request reports