Add deterministic ordering to roulette assignment table
What does this MR do?
Creates deterministic reviewer assignment table ordering.
Before, depending on order of files in the review, sometimes we'd have the backend
row before the frontend
row and sometimes it would be reversed.
This was a bit of an annoyance when managing 2 different MR's and messaging reviewers on MR's that have both frontend
and backend
reviewers.
process:
- open first MR
- scroll to danger output, copy
frontend
reviewer name(1st row in the table) - scroll down to the bottom, reference them in a comment asking for a
frontend
review. - open second MR
- scroll to danger output, copy what you think is
frontend
reviewer line - 1st row in table - but is reallybackend
reviewer - scroll down to the bottom, reference them and mistakenly assume the order is the same b/t mr's and ask for a
frontend
review
This MR will order it so that all MRs will order the assignment rows by category.
Screenshots (strongly suggested)
Before this change non-deterministic order...
1st MR has rows backend
then frontend
2nd MR has frontend
then backend
rows
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Doug Stull