Skip to content

Migrate merge conflicts modal

David O'Regan requested to merge 229677-mr-conflicts into master

What does this MR do?

A tiny MVC for #229677 (closed) where we migrate all the old HAML code for this modal to a new Vue app. This effort is broken into 5 merges.

What Merge
Add new modal and replace mr_widget_header !47889 (merged)
Update mr_widget_conflicts 🤘
Update mr_widget_conflicts_warning TBA
Update mr_widget_conflicts_help TBA
Remove _how_to_merge.html.haml and extra JS TBA

Screenshot_2020-11-16_at_11.01.54

Screenshots (strongly suggested)

Before After
Screenshot_2020-11-23_at_16.05.38 Screenshot_2020-11-23_at_16.22.34
Screenshot_2020-11-23_at_16.05.44 Screenshot_2020-11-23_at_16.22.41

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related to #229677 (closed)

Edited by David O'Regan

Merge request reports