Skip to content

Add filter bar to group members view

What does this MR do?

Related to #228675 (closed)

Adds a filtered search bar to the group members view.

There will be a dropdown with sort options added in the next MR. To keep this MR as small as possible it only adds the filtered search bar.

Local testing

Currently behind the group_members_filtered_search feature flag

  1. bin/rails console
  2. Feature.enable(:group_members_filtered_search)
  3. Create a group
  4. Add members in "Group" -> "Members"
  5. Use the filtered search bar to filter the members

Caveats

  • Sort dropdown is not yet implemented, will be in a subsequent MR
  • Mixing direct member filter with 2FA filter is not yet supported by the backend, will be fixed in !48084 (merged)

Screenshots (strongly suggested)

View Before After
Empty Screen_Shot_2020-11-30_at_12.08.38_PM Screen_Shot_2020-11-30_at_12.02.23_PM
Search Screen_Shot_2020-11-30_at_12.09.04_PM Screen_Shot_2020-11-30_at_12.02.39_PM
With filters Screen_Shot_2020-11-30_at_12.09.38_PM Screen_Shot_2020-11-30_at_12.01.49_PM
Groups tab Screen_Shot_2020-11-30_at_12.10.07_PM Screen_Shot_2020-11-30_at_12.17.31_PM
Invited tab Screen_Shot_2020-11-30_at_12.10.35_PM Screen_Shot_2020-11-30_at_12.18.21_PM
Access requests tab Screen_Shot_2020-11-30_at_12.11.44_PM Screen_Shot_2020-11-30_at_12.18.37_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Peter Hegman

Merge request reports