Skip to content
Snippets Groups Projects

Refactor CI/CD analytics page to GraphQL

Merged Jose Ivan Vargas requested to merge jivanvl-migrate-analytics-graphql into master
All threads resolved!

What does this MR do?

This refactors the Analytics -> CI/CD page to use GraphQL instead of sending the data via DOM attributes, per our OKR of reducing the LCP (Largest Content Paint) across GitLab. All of the changes are set behind the :graphql_pipeline_analytics feature flag

#285147 (closed)

Rollout issue for this feature change is in:

#290153 (closed)

You can try this feature change locally by accessing the rails console and issuing the following command

Feature.enable(:graphql_pipeline_analytics)

Screenshots (strongly suggested)

No visual changes, only some of the frontend logic as to how some data is requested has been changed, plus the necessary backend to make the changes possible

Does this MR meet the acceptance criteria?

Conformity

Edited by Jose Ivan Vargas

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Jose Ivan Vargas added 232 commits

    added 232 commits

    Compare with previous version

  • Jose Ivan Vargas added 128 commits

    added 128 commits

    Compare with previous version

  • added 1 commit

    • 392b8bbb - Refactor CI/CD analytics page to GraphQL

    Compare with previous version

  • Jose Ivan Vargas mentioned in merge request !48198 (closed)

    mentioned in merge request !48198 (closed)

  • Jose Ivan Vargas added 215 commits

    added 215 commits

    Compare with previous version

  • added 1 commit

    • 8611757f - Refactor CI/CD analytics page to GraphQL

    Compare with previous version

  • Jose Ivan Vargas added 178 commits

    added 178 commits

    Compare with previous version

  • added 1 commit

    • 5f239825 - Refactor CI/CD analytics page to GraphQL

    Compare with previous version

  • added 1 commit

    • 5bf1e840 - Refactor CI/CD analytics page to GraphQL

    Compare with previous version

  • Jose Ivan Vargas marked the checklist item Code review guidelines as completed

    marked the checklist item Code review guidelines as completed

  • Jose Ivan Vargas marked the checklist item Merge request performance guidelines as completed

    marked the checklist item Merge request performance guidelines as completed

  • Jose Ivan Vargas marked the checklist item Style guides as completed

    marked the checklist item Style guides as completed

  • Jose Ivan Vargas marked this merge request as ready

    marked this merge request as ready

  • Jose Ivan Vargas
  • @jivanvl It's looking good, just had a few comments...

  • Brett Walker assigned to @jivanvl and unassigned @digitalmoksha

    assigned to @jivanvl and unassigned @digitalmoksha

  • assigned to @jivanvl and unassigned @f_caplette

  • Jose Ivan Vargas added 2209 commits

    added 2209 commits

    Compare with previous version

  • assigned to @digitalmoksha and @f_caplette and unassigned @jivanvl

  • Frédéric Caplette approved this merge request

    approved this merge request

  • Brett Walker approved this merge request

    approved this merge request

  • Douglas Barbosa Alexandre approved this merge request

    approved this merge request

    • Resolved by Sarah Groff Hennigh-Palermo

      @jivanvl I've finished the review we started in the pairing section. I'd really like to encourage you to break the backend and frontend into separate MRs. As we discussed, I'm not certain if this is still the case, but previously we've had issues rolling out changes to the backend and frontend together because they are not necessarily distributed to servers together and this can cause a frontend to make a call to a backend that does not yet exist.

      If you'd like, you can leave this MR for the backend and open a new one with the frontend changes. I'll still have the context from here, and I don't mind working that way.

      WDYT?

  • mentioned in issue #292085

  • Jose Ivan Vargas mentioned in merge request !49384 (merged)

    mentioned in merge request !49384 (merged)

  • Jose Ivan Vargas added 425 commits

    added 425 commits

    Compare with previous version

  • added 1 commit

    • a438cb45 - Refactor tests and improve error handling

    Compare with previous version

  • added 1 commit

    • 15a2efee - Refactor tests and improve error handling

    Compare with previous version

  • assigned to @jivanvl and unassigned @sarahghp

  • Jose Ivan Vargas added 616 commits

    added 616 commits

    Compare with previous version

  • Jose Ivan Vargas assigned to @sarahghp and unassigned @jivanvl

    assigned to @sarahghp and unassigned @jivanvl

  • resolved all threads

  • Sarah Groff Hennigh-Palermo enabled an automatic merge when the pipeline for 9ee32679 succeeds

    enabled an automatic merge when the pipeline for 9ee32679 succeeds

  • Sarah Groff Hennigh-Palermo canceled the automatic merge

    canceled the automatic merge

  • mentioned in commit f87e72cd

  • Jose Ivan Vargas mentioned in merge request !49638 (merged)

    mentioned in merge request !49638 (merged)

  • added workflowcanary label and removed workflowstaging label

  • Jose Ivan Vargas mentioned in merge request !49760 (merged)

    mentioned in merge request !49760 (merged)

  • Jose Ivan Vargas mentioned in merge request !49846 (merged)

    mentioned in merge request !49846 (merged)

  • mentioned in issue #290153 (closed)

  • mentioned in issue #293901 (closed)

  • Jose Ivan Vargas mentioned in merge request !51504 (merged)

    mentioned in merge request !51504 (merged)

  • Jose Ivan Vargas mentioned in merge request !52967 (merged)

    mentioned in merge request !52967 (merged)

  • added workflowproduction label and removed workflowcanary label

  • Please register or sign in to reply
    Loading