Refactor CI/CD analytics page to GraphQL
What does this MR do?
This refactors the Analytics -> CI/CD page to use GraphQL instead of sending the data via DOM attributes, per our OKR of reducing the LCP (Largest Content Paint) across GitLab. All of the changes are set behind the :graphql_pipeline_analytics
feature flag
Rollout issue for this feature change is in:
You can try this feature change locally by accessing the rails console and issuing the following command
Feature.enable(:graphql_pipeline_analytics)
Screenshots (strongly suggested)
No visual changes, only some of the frontend logic as to how some data is requested has been changed, plus the necessary backend to make the changes possible
Does this MR meet the acceptance criteria?
Conformity
Merge request reports
Activity
changed milestone to %13.7
added backend label
1 Warning This merge request is quite big (more than 883 lines changed), please consider splitting it into multiple merge requests. 1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, run the following:
bin/changelog -m 48267 "Refactor CI/CD analytics page to GraphQL"
If you want to create a changelog entry for GitLab EE, run the following instead:
bin/changelog --ee -m 48267 "Refactor CI/CD analytics page to GraphQL"
If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer backend Giorgenes Gelatti ( @ggelatti
) (UTC+11, 17 hours ahead of@jivanvl
)Douglas Barbosa Alexandre ( @dbalexandre
) (UTC-3, 3 hours ahead of@jivanvl
)frontend Justin Boyson ( @jboyson
) (UTC-6, same timezone as@jivanvl
)Andrew Fontaine ( @afontaine
) (UTC-5, 1 hour ahead of@jivanvl
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by 🤖 GitLab Bot 🤖Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits c5995a35 and 82351981
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.03 MB 3.03 MB +1.87 KB 0.1 % mainChunk 1.88 MB 1.88 MB - 0.0 % Significant Growth: 1Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.projects.pipelines.charts 3.22 MB 3.83 MB +630.46 KB 19.1 %
Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.
Please consider pinging someone from the FE Foundations (
@dmishunov
,@justin_ho
,@mikegreiling
or@nmezzopera
) for review, if you are unsure about the size increase.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerEdited by 🤖 GitLab Bot 🤖added 188 commits
-
41d8ef42...127db4b9 - 187 commits from branch
master
- 4b872649 - Refactor CI/CD analytics page to GraphQL
-
41d8ef42...127db4b9 - 187 commits from branch
added 154 commits
-
4b872649...14a4c5dd - 153 commits from branch
master
- aa43ac58 - Refactor CI/CD analytics page to GraphQL
-
4b872649...14a4c5dd - 153 commits from branch
- Resolved by Jose Ivan Vargas
added 232 commits
-
aa43ac58...853b7ea2 - 231 commits from branch
master
- 1aec95a5 - Refactor CI/CD analytics page to GraphQL
-
aa43ac58...853b7ea2 - 231 commits from branch
added 128 commits
-
1aec95a5...1ebf531a - 127 commits from branch
master
- c67595fd - Refactor CI/CD analytics page to GraphQL
-
1aec95a5...1ebf531a - 127 commits from branch
mentioned in merge request !48198 (closed)
added 215 commits
-
392b8bbb...ed5ba395 - 214 commits from branch
master
- db97e3e6 - Refactor CI/CD analytics page to GraphQL
-
392b8bbb...ed5ba395 - 214 commits from branch
added documentation label
added 178 commits
-
8611757f...45b38556 - 177 commits from branch
master
- a1f28bc0 - Refactor CI/CD analytics page to GraphQL
-
8611757f...45b38556 - 177 commits from branch
marked the checklist item Code review guidelines as completed
marked the checklist item Merge request performance guidelines as completed
marked the checklist item Style guides as completed
- Resolved by Jose Ivan Vargas
- Resolved by Jose Ivan Vargas
- Resolved by Jose Ivan Vargas
@f_caplette Can you please take a look at the frontend?
@digitalmoksha Can you please take a look at the backend?
Thanks!
assigned to @f_caplette and @digitalmoksha
- Resolved by Jose Ivan Vargas
- Resolved by Brett Walker
- Resolved by Brett Walker
- Resolved by Brett Walker
@jivanvl It's looking good, just had a few comments...
assigned to @jivanvl and unassigned @digitalmoksha
- Resolved by Jose Ivan Vargas
- Resolved by Jose Ivan Vargas
- Resolved by Sarah Groff Hennigh-Palermo
- Resolved by Sarah Groff Hennigh-Palermo
- Resolved by Jose Ivan Vargas
- Resolved by Jose Ivan Vargas
- Resolved by Jose Ivan Vargas
- Resolved by Jose Ivan Vargas
- Resolved by Jose Ivan Vargas
- Resolved by Jose Ivan Vargas
- Resolved by Jose Ivan Vargas
- Resolved by Jose Ivan Vargas
unassigned @jivanvl
assigned to @jivanvl and unassigned @f_caplette
added 2209 commits
-
5bf1e840...4f37e9d5 - 2206 commits from branch
master
- 2f919c41 - Refactor CI/CD analytics page to GraphQL
- 95328953 - Rename fields and add specs
- 4efc7051 - Rename legacy and new components
Toggle commit list-
5bf1e840...4f37e9d5 - 2206 commits from branch
- Resolved by Jose Ivan Vargas
@f_caplette I addressed the comments from the frontend side, can you please take a look? I left you some comments regarding the CSS changes
@digitalmoksha I addressed the backend changes as well, can you please take a look?
assigned to @digitalmoksha and @f_caplette and unassigned @jivanvl
unassigned @f_caplette
assigned to @jivanvl
unassigned @digitalmoksha and @jivanvl
- Resolved by Sarah Groff Hennigh-Palermo
- Resolved by Jose Ivan Vargas
- Resolved by Jose Ivan Vargas
- Resolved by Jose Ivan Vargas
- Resolved by Jose Ivan Vargas
- Resolved by Sarah Groff Hennigh-Palermo
- Resolved by Sarah Groff Hennigh-Palermo
- Resolved by Sarah Groff Hennigh-Palermo
- Resolved by Jose Ivan Vargas
- Resolved by Sarah Groff Hennigh-Palermo
- Resolved by Sarah Groff Hennigh-Palermo
@jivanvl I've finished the review we started in the pairing section. I'd really like to encourage you to break the backend and frontend into separate MRs. As we discussed, I'm not certain if this is still the case, but previously we've had issues rolling out changes to the backend and frontend together because they are not necessarily distributed to servers together and this can cause a frontend to make a call to a backend that does not yet exist.
If you'd like, you can leave this MR for the backend and open a new one with the frontend changes. I'll still have the context from here, and I don't mind working that way.
WDYT?
mentioned in issue #292085
mentioned in merge request !49384 (merged)
added 425 commits
-
4efc7051...349c97ad - 423 commits from branch
master
- 0822db83 - Refactor CI/CD analytics page to GraphQL
- d41aa440 - Refactor tests and improve error handling
-
4efc7051...349c97ad - 423 commits from branch
mentioned in issue gitlab-org/quality/triage-reports#1138 (closed)
assigned to @sarahghp
- Resolved by Sarah Groff Hennigh-Palermo
added 616 commits
-
15a2efee...c5995a35 - 614 commits from branch
master
- 666bbc50 - Refactor CI/CD analytics page to GraphQL
- 82351981 - Refactor tests and improve error handling
-
15a2efee...c5995a35 - 614 commits from branch
enabled an automatic merge when the pipeline for 9ee32679 succeeds
mentioned in commit f87e72cd
added workflowstaging label and removed workflowready for development label
mentioned in merge request !49638 (merged)
added workflowcanary label and removed workflowstaging label
mentioned in issue gitlab-com/www-gitlab-com#9644 (closed)
mentioned in merge request !49760 (merged)
mentioned in merge request !49846 (merged)
mentioned in issue #290153 (closed)
mentioned in issue #293901 (closed)
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request !51504 (merged)
mentioned in merge request !52967 (merged)
added workflowproduction label and removed workflowcanary label
removed typefeature label
added Category:Pipeline Composition label
added grouppipeline authoring label and removed grouppipeline execution label