Add successful experiment cleanup template
What does this MR do?
Adds successful experiment template for cleanup - contributing to gitlab-org/growth/team-tasks#235 (closed)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Contributes to gitlab-org/growth/team-tasks#235 (closed)
Closes https://gitlab.com/gitlab-org/growth/experimentation/-/issues/6
Merge request reports
Activity
changed milestone to %13.7
added devopsgrowth documentation maintenanceworkflow workflowin dev + 1 deleted label
added tooling (archive) label
- Resolved by Doug Stull
@gitlab-org/growth/experiment-devs please take a look and give your thoughts. I don't expect this to be perfect as-is, and I only created this as a starter based on experiences in https://gitlab.com/gitlab-org/gitlab/-/issues/267492.
I would like to keep successful(bad word - perhaps converted is better?) and not successful(to be fully removed from codebase) templates separate as I do not like if/else logic when using a checklist as I've leveraged in the template. I find when not all checklist type items apply to a situation, eventually, the checklist starts getting ignored.
/cc @pcalder
mentioned in issue gitlab-org/growth/team-tasks#235 (closed)
- Resolved by Phil Calder
- Resolved by Doug Stull
added sectiongrowth label
- Resolved by Doug Stull
Still getting pinged after 9 months for bugs for a conversion experiment. Should we create a "handover issue" to the appropriate team PM & engineering?
- Open an experiment feature handover issue to the relevant team, with steps and assign to the PM and EM with relevant issue and MR
That issue can consist of the following review steps
- Links to experiment, tracking and other issues and MRs
- Any future iterations - such as rollout to self-managed, rollout to more X...
- Resolved by Doug Stull
mentioned in issue #287680 (closed)
- Resolved by Phil Calder
- Resolved by Doug Stull
- Resolved by Phil Calder
- Resolved by Phil Calder
@dstull today I have started cleaning up a non-successful experiment - #287680 (closed), and the steps here didn't apply. Not to make this MR busy - after the points of this MR are finalized, we may create a template for this scenario.
Or should we really have one single template?
- Resolved by Phil Calder
mentioned in commit f6f4b14e
- Resolved by Phil Calder
assigned to @a_akgun
added workflowstaging label and removed workflowin dev label
added releasedcandidate label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added releasedpublished label and removed releasedcandidate label
added typemaintenance label and removed tooling (archive) label