Skip to content

Enable alert management for configured http integrations

Sarah Yasonik requested to merge sy-fix-alerts-active-state into master

What does this MR do?

This fixes a priority1 severity1 (see UX section of https://about.gitlab.com/handbook/engineering/quality/issue-triage/#severity) ~bug which prevents new HTTP alert integrations from enabling the alert list. #285481 (closed)

I'm in the middle of cleaning up any alerts service code on another branch, so that's not the intention of this change. The scope of this change is the minimum needed to solve the bug.

Screenshots

Project has single HTTP integration enabled Alert management page loads!
Screen_Shot_2020-11-20_at_10.31.32_AM Screen_Shot_2020-11-20_at_10.31.59_AM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Peter Leitzen

Merge request reports