Skip to content

Changes image diff comments to use percents

What does this MR do?

Changes the positioning type of the image diff notes. Instead of using absolute X & Y positions, we will now use percents. The percent will allow for the comment bubble to adjust depending on screen size. However, the X & Y will still get stored in the database as an X & Y, not a percent.

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #225961 (closed)

Edited by Phil Hughes

Merge request reports