Geo - Update Fontawesome Icons
What does this MR do?
Closes #284653 (closed)
There were a few cases where legacy Geo code was using old deprecated Fontawesome icons. Some of the icons had already been removed from the stylesheet and thus weren't even showing up in the UI. This only affects the legacy Geo Projects and Uploads Views.
As an additional note the views affected by this change are already deprecated and should be removed in an upcoming milestone:
Geo Projects: #216319 (closed)
Geo Uploads: #216317 (closed)
There were also a couple of methods that had no usages that used fontawesome icons, so I simply removed the methods entirely.
I have confirmed that all the icons now work (again) using GitLab SVGs.
Screenshots (strongly suggested)
| Icon | |
|---|---|
| Synced |  |
| Pending |  |
| Failed |  |
| Never |  |
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry - [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers - [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec - [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Related to #284653 (closed)