Skip to content

Fix `project` attribute of `StoreScanService` class

Mehmet Emin INAC requested to merge 267021_fix_ff_access into master

What does this MR do?

While building this feature, I got feedback to extend the service class from ::Base service class which has an attr_accessor defined for the project attribute therefore even though we didn't have a project set for this class, it wasn't raising an error and we couldn't catch the issue, neither with unit tests nor with manual tests on staging because on the test and staging environments the feature flag was globally enabled.

Related to #267021 (closed)

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Mehmet Emin INAC

Merge request reports