Skip to content

Resolve "FE default emoji icon persists after clearing status"

What does this MR do?

Fixes the default status emoji persisting in the comment (notes) once a user's status has been cleared

  • Ensures we have preloaded a user's status
  • Checks if we have a custom status set before displaying the default emoji in a comment header
  • Adds an additional feature spec
  • Updates the note header specs

Screenshots (strongly suggested)

Before After
Screen_Shot_2020-11-23_at_11.56.55_pm Screen_Shot_2020-11-23_at_11.55.43_pm

Testing instructions

Ensure the feature flag is enabled

From the set status modal

  1. Set your availability status !46844 (merged)
  2. The text "Busy" should appear next to your name in various locations
  3. Clear your status and view any issue / MR you've commented

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #284601 (closed)

Edited by Ezekiel Kigbo

Merge request reports