Skip to content
Snippets Groups Projects

Removed boards promotion [RUN AS-IF-FOSS]

Merged Donald Cook requested to merge 260439-remove-boards-upsell-list into master
All threads resolved!

What does this MR do?

Removed code to upsell within boards.

Screenshots (strongly suggested)

Before After
Screen_Shot_2020-11-17_at_2.20.04_PM Screen_Shot_2020-11-17_at_2.19.32_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related to #260439 (closed)

Edited by Simon Knox

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Donald Cook added 1 commit

    added 1 commit

    Compare with previous version

  • Désirée Chevalier approved this merge request

    approved this merge request

  • 🤖 GitLab Bot 🤖 changed milestone to %13.7

    changed milestone to %13.7

  • Donald Cook added 4144 commits

    added 4144 commits

    Compare with previous version

  • Donald Cook added 1 commit

    added 1 commit

    • 832f30ea - Removed the rest of the promotion code

    Compare with previous version

  • Donald Cook added 2 commits

    added 2 commits

    Compare with previous version

  • Donald Cook added 1 commit

    added 1 commit

    Compare with previous version

  • Donald Cook added 1 commit

    added 1 commit

    • f390f7fa - Removed the rest of the promotion code

    Compare with previous version

  • Donald Cook added 2 commits

    added 2 commits

    • f95612d4 - Removed boards promotion
    • 909a1ccd - Removed the rest of the promotion code

    Compare with previous version

  • Donald Cook marked the checklist item Tested in all supported browsers as completed

    marked the checklist item Tested in all supported browsers as completed

  • Donald Cook changed the description

    changed the description

  • Donald Cook added 1 commit

    added 1 commit

    • d6aa1426 - Removed a few more promotion instances

    Compare with previous version

  • Florie Guibert approved this merge request

    approved this merge request

  • Donald Cook added 1 commit

    added 1 commit

    • 83005b1b - Couple more leftover promotion code removal

    Compare with previous version

  • assigned to @psimyn

  • Florie Guibert
  • Donald Cook added 1 commit

    added 1 commit

    Compare with previous version

  • Simon Knox
  • Simon Knox
  • Simon Knox changed title from Removed boards promotion to Removed boards promotion [RUN AS-IF-FOSS]

    changed title from Removed boards promotion to Removed boards promotion [RUN AS-IF-FOSS]

  • Simon Knox requested review from @psimyn

    requested review from @psimyn

  • Simon Knox added 1 commit

    added 1 commit

    • b8138ff5 - Apply 2 suggestion(s) to 2 file(s)

    Compare with previous version

  • Simon Knox approved this merge request

    approved this merge request

  • Donald Cook added 1 commit

    added 1 commit

    Compare with previous version

  • Simon Knox resolved all threads

    resolved all threads

  • merged

  • Simon Knox mentioned in commit ea6ecacd

    mentioned in commit ea6ecacd

  • added workflowstaging label and removed workflowin review label

  • added workflowcanary label and removed workflowstaging label

  • added workflowproduction label and removed workflowcanary label

  • Please register or sign in to reply
    Loading