Removed boards promotion [RUN AS-IF-FOSS]
What does this MR do?
Removed code to upsell within boards.
Screenshots (strongly suggested)
Before | After |
---|---|
![]() |
![]() |
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry - [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
- [-] Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers - [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods - [-] Security reports checked/validated by a reviewer from the AppSec team
Related to #260439 (closed)
Merge request reports
Activity
changed milestone to %13.6
- Resolved by Simon Knox
@msedlakjakubowski Do we refer to the upsell call to action in boards anywhere in our docs?
2 Warnings This merge request changed files with disabled eslint rules. Please consider fixing them. This MR has a Changelog file outside ee/
, but code changes inee/
. Consider moving the Changelog file intoee/
.Disabled eslint rules
The following files have disabled
eslint
rules. Please consider fixing them:app/assets/javascripts/boards/constants.js
app/assets/javascripts/boards/stores/actions.js
ee/app/assets/javascripts/boards/models/list.js
ee/app/assets/javascripts/boards/stores/actions.js
ee/app/assets/javascripts/boards/stores/boards_store_ee.js
Run the following command for more details
node_modules/.bin/eslint --report-unused-disable-directives --no-inline-config \ 'app/assets/javascripts/boards/constants.js' \ 'app/assets/javascripts/boards/stores/actions.js' \ 'ee/app/assets/javascripts/boards/models/list.js' \ 'ee/app/assets/javascripts/boards/stores/actions.js' \ 'ee/app/assets/javascripts/boards/stores/boards_store_ee.js'
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer frontend Tomas Vik ( @viktomas
) (UTC+1, 9 hours ahead of@donaldcook
)Simon Knox ( @psimyn
) (UTC+11, 19 hours ahead of@donaldcook
)test Quality for spec/features/*
Désirée Chevalier ( @dchevalier2
) (UTC-5, 3 hours ahead of@donaldcook
)Maintainer review is optional for test Quality for spec/features/*
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by 🤖 GitLab Bot 🤖Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 8ba36cd0 and 108da508
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.03 MB 3.03 MB - -0.0 % mainChunk 1.88 MB 1.88 MB - 0.0 %
Note: We do not have exact data for 8ba36cd0. So we have used data from: 470d538d.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerEdited by 🤖 GitLab Bot 🤖- Resolved by Simon Knox
@dchevalier2 Can you take a look at this MR please? Removed a feature (promotion of boards) and the rspec tests with it.
assigned to @dchevalier2
- Resolved by Simon Knox
@fguibert Can you please review this? May have missed some artifacts (in the store?) but think we can just remove the rest as part of the refactor?
assigned to @fguibert
marked the checklist item Changelog entry as completed
marked the checklist item Code review guidelines as completed
marked the checklist item Merge request performance guidelines as completed
marked the checklist item Style guides as completed
- Resolved by Donald Cook
unassigned @dchevalier2
changed milestone to %13.7
added missed-deliverable missed:13.6 labels
added 4144 commits
-
a725a695...ecc20f06 - 4142 commits from branch
master
- 38540ffb - Removed boards promotion
- 8810f8a4 - Removed unused Vuex code
-
a725a695...ecc20f06 - 4142 commits from branch
added 2 commits
added 2 commits
marked the checklist item Tested in all supported browsers as completed
marked the checklist item Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. as completed
- Resolved by Donald Cook
unassigned @fguibert
assigned to @psimyn
- Resolved by Simon Knox
- Resolved by Simon Knox
- Resolved by Simon Knox
requested review from @psimyn
mentioned in commit ea6ecacd
added workflowstaging label and removed workflowin review label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label