Skip to content

Migrate user admin deactivate user modal to GlModal

Doug Stull requested to merge 267118-migrate-delete-user-to-confirm-modal into master

What does this MR do?

Migrates to use the confirm modal for ease of updating in the future.

Note: no changelog since this was mostly a developer facing change.

Test Locally - with a user that has no activity

  • Individual User: Visit admin/users area and click on any user - similar to http://127.0.0.1:3000/admin/users/asdfasdf
  • User Index: Visit admin/users area and use dropdown on any user - http://127.0.0.1:3000/admin/users

Screenshots (strongly suggested)

Same as before - background development work only.

Individual User

Screen_Shot_2020-11-17_at_2.55.34_PM

Screen_Recording_2020-11-17_at_3.02.18_PM

User index

Screen_Shot_2020-11-17_at_3.06.19_PM

Screen_Recording_2020-11-17_at_3.07.07_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #267118

Edited by Doug Stull

Merge request reports