Add caching for ES migration_has_finished?
What does this MR do?
This MR adds a caching layer to the Elastic::DataMigrationService.migration_has_finished?
method. We plan to call it each time we build an Elasticsearch query when we have before and after migration states, so it needs to be performant.
This MR doesn't have a changelog entry since it's not a user-facing change and we don't have the code which calls this method yet.
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Related to #281680 (closed)
Edited by Dmitry Gruzd