Skip to content

Fix Ruby 2.7 deprecation warnings in spec/requests/git_http_spec.rb

Dmitry Gruzd requested to merge 257438-fix-git-http-spec-kwargs-deprecation into master

What does this MR do?

In Ruby 3.0, positional arguments and keyword arguments will be separated. Ruby 2.7 will warn for behaviors that will change in Ruby 3.0. In most cases, you can avoid the incompatibility by adding the double splat operator. It explicitly specifies passing keyword arguments instead of a Hash object.

Part of #257438 (closed)

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #257438 (closed)

Edited by Dmitry Gruzd

Merge request reports